Export liveness information of Yul SSA CFG #15608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0qs
commented
Dec 3, 2024
| { | ||
| auto const valueToString = [&](SSACFG::ValueId const& valueId) { return varToString(_cfg, valueId); }; |
There was a problem hiding this comment.
I guess we could generalize the SSACFGPrinter and reuse it in the exporter, so the cfg and the dot exporter could be an instance that implements its own writeBlock and "writeFunction" for different output formats.
There was a problem hiding this comment.
Yeah, there's a lot of duplication here :)
There was a problem hiding this comment.
I will address that in a follow-up PR :)
clonker
reviewed
Dec 3, 2024
clonker
reviewed
Dec 3, 2024
r0qs
force-pushed
the
yul-cfg-liveness-export
branch
from
855c525 to
cb5ad43
Compare
clonker
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.