Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yul: Change Dialect definition into a class. #15617

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

clonker
Copy link
Member

@clonker clonker commented Dec 6, 2024

Changes Yul dialect from struct to class to be consistent with EVMDialect. Follow-up of PR #15347.

@clonker clonker added refactor has dependencies The PR depends on other PRs that must be merged first labels Dec 6, 2024
cameel
cameel previously approved these changes Dec 6, 2024
@clonker clonker force-pushed the builtin_ast_element branch 2 times, most recently from fca7d33 to 8994d85 Compare December 9, 2024 07:37
@clonker clonker force-pushed the make_yul_dialect_into_class branch from 0044cd6 to bf80d43 Compare December 9, 2024 07:45
Base automatically changed from builtin_ast_element to develop December 9, 2024 14:07
@clonker clonker dismissed cameel’s stale review December 9, 2024 14:07

The base branch was changed.

@cameel cameel force-pushed the make_yul_dialect_into_class branch from bf80d43 to 5efaa66 Compare December 9, 2024 18:57
@cameel cameel removed the has dependencies The PR depends on other PRs that must be merged first label Dec 9, 2024
@ekpyron ekpyron merged commit 3a37e56 into develop Dec 9, 2024
73 checks passed
@ekpyron ekpyron deleted the make_yul_dialect_into_class branch December 9, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants