Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename couponCollection.js -> CouponCollection.js #426

Merged

Conversation

tiberiuichim
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

There was a previous PR merged that I've authored, but I could not check that my commits are ok. There seems to be a problem with it. Let's hope now it's fixed.

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@tiberiuichim
Copy link
Contributor Author

@treoden I think my previous PR had a problem, I couldn't test the evershop in my custom app. Let's see if it's now ok.

My test right now has been to yalc publish in my evershop repo packages/evershop, then yalc add @evershop/evershop to test the fixed package. The app seems to start.

@treoden
Copy link
Collaborator

treoden commented Jan 3, 2024

oh shit. I did not noticed this. Yeah the CouponCollection service should not be renamed

@treoden treoden merged commit fadc3e9 into evershopcommerce:main Jan 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants