Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvement on the enhanced switch block explanation #2899

Merged
merged 8 commits into from
Jan 7, 2025

Conversation

josealonso
Copy link
Contributor

Small improvement on the enhanced switch block explanation

Add example with guarded patterns and which LTS Java versions have these features.


Reviewer Resources:

Track Policies

Add example with guarded patterns and which LTS Java versions have these features.
@josealonso
Copy link
Contributor Author

josealonso commented Jan 3, 2025

This PR substitutes the #2893
However, as a user I didn't see this text after completing the football-match-reports exercise.
@kahgoh @sanderploegsma

@josealonso josealonso marked this pull request as ready for review January 3, 2025 16:47
concepts/switch-statement/about.md Outdated Show resolved Hide resolved
concepts/switch-statement/about.md Outdated Show resolved Hide resolved
concepts/switch-statement/about.md Outdated Show resolved Hide resolved
concepts/switch-statement/about.md Outdated Show resolved Hide resolved
concepts/switch-statement/about.md Outdated Show resolved Hide resolved
@josealonso
Copy link
Contributor Author

josealonso commented Jan 3, 2025

I think I have to add the URL to the links.json file. I don't know how to do it in this web interface.
I'll try to do it this weekend. Thanks for your suggestions, @kahgoh!!

@josealonso josealonso requested a review from kahgoh January 6, 2025 13:17
@josealonso
Copy link
Contributor Author

I think it's ready now. I'm sorry I didn't finish it earlier, @kahgoh

Copy link
Member

@kahgoh kahgoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the PR!

@kahgoh kahgoh merged commit d53f6ab into exercism:main Jan 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants