Make all generators know the dim #513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Some of the generators know the dimensionality of the search space but others don't. Unified the API such that every generator has a dim attribute. This allows other classes working with generators to be able to always access the dimensionality (even if the bounds are not available). Differential Revision: D67997208
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67997208 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Jan 10, 2025
Summary: Some of the generators know the dimensionality of the search space but others don't. Unified the API such that every generator has a dim attribute. This allows other classes working with generators to be able to always access the dimensionality (even if the bounds are not available). Differential Revision: D67997208
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Jan 10, 2025
Summary: Some of the generators know the dimensionality of the search space but others don't. Unified the API such that every generator has a dim attribute. This allows other classes working with generators to be able to always access the dimensionality (even if the bounds are not available). Differential Revision: D67997208
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Jan 10, 2025
Summary: Some of the generators know the dimensionality of the search space but others don't. Unified the API such that every generator has a dim attribute. This allows other classes working with generators to be able to always access the dimensionality (even if the bounds are not available). Differential Revision: D67997208
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Jan 10, 2025
Summary: Some of the generators know the dimensionality of the search space but others don't. Unified the API such that every generator has a dim attribute. This allows other classes working with generators to be able to always access the dimensionality (even if the bounds are not available). Differential Revision: D67997208
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Jan 10, 2025
Summary: Some of the generators know the dimensionality of the search space but others don't. Unified the API such that every generator has a dim attribute. This allows other classes working with generators to be able to always access the dimensionality (even if the bounds are not available). Differential Revision: D67997208
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Jan 10, 2025
Summary: Some of the generators know the dimensionality of the search space but others don't. Unified the API such that every generator has a dim attribute. This allows other classes working with generators to be able to always access the dimensionality (even if the bounds are not available). Reviewed By: crasanders Differential Revision: D67997208
|
This pull request has been merged in feb92c9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Some of the generators know the dimensionality of the search space but others don't. Unified the API such that every generator has a dim attribute. This allows other classes working with generators to be able to always access the dimensionality (even if the bounds are not available).
Differential Revision: D67997208