Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect documentation specification #461

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Anon-im
Copy link
Contributor

@Anon-im Anon-im commented Jan 19, 2025

Motivation

The constructor specifies that the url is set “forever”, but this is not reflected in the variable comment:

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers.


PR-Codex overview

This PR updates the documentation for the url variable in the src/FnameResolver.sol file to clarify that it is set once during deployment and cannot be changed.

Detailed summary

  • Updated the comment for the url variable to specify that it is set once during deployment and cannot be changed.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant