You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces a new RPC method for pruning messages, along with related request and response message definitions in Protobuf. It updates various components to support this functionality, including adjustments to logging, message handling, and scheduling.
Detailed summary
Added PruneMessagesRequest and PruneMessagesResponse messages in protobufs/schemas/request_response.proto.
Introduced PruneMessages RPC method in protobufs/schemas/rpc.proto.
Updated clearCachedMessageCount method in storeEventHandler.ts.
Modified DEFAULT_PRUNE_MESSAGES_JOB_CRON to run every 5 minutes in pruneMessagesJob.ts.
Enhanced logging in adminServer.ts for pruning messages.
Implemented pruneMessages method in AdminService and AdminServiceClient.
Updated ingestMessagesFromDb to call pruneMessages after submitting messages.
Adjusted various files to accommodate new pruning logic and improve error handling.
✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aditiharini
force-pushed
the
migration-ingest-copy
branch
from
Why is this change needed?
Describe why this issue should be fixed and link to any relevant design docs, issues or other relevant items.
Merge Checklist
Choose all relevant options below by adding an
xnow or at any time before submitting for reviewPR-Codex overview
This PR introduces a new RPC method for pruning messages, along with related request and response message definitions in Protobuf. It updates various components to support this functionality, including adjustments to logging, message handling, and scheduling.
Detailed summary
PruneMessagesRequestandPruneMessagesResponsemessages inprotobufs/schemas/request_response.proto.PruneMessagesRPC method inprotobufs/schemas/rpc.proto.clearCachedMessageCountmethod instoreEventHandler.ts.DEFAULT_PRUNE_MESSAGES_JOB_CRONto run every 5 minutes inpruneMessagesJob.ts.adminServer.tsfor pruning messages.pruneMessagesmethod inAdminServiceandAdminServiceClient.ingestMessagesFromDbto callpruneMessagesafter submitting messages.