fix: Fix error handling Update index.ts #2476
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change needed?
The error handling in the userdata fetch block assumes the error object always has a
response
property, which isn't guaranteed. This can cause crashes if the error is unrelated to an HTTP request (e.g., network issues or code errors).I've updated the
console.error
statement to safely handle cases wheree.response
is undefined. Now it logs either the response data or the error message, preventing potential runtime errors.Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewPR-Codex overview
This PR improves error handling in the
packages/hub-web/examples/profile/index.ts
file by making the error logging more robust. It adds a fallback to log the error message if the response data is not available.Detailed summary
catch
block.console.error
to loge.response?.data
or fallback toe.message
ife.response.data
is undefined.