Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #18 export Mutators type declaration #20

Merged
merged 1 commit into from
Feb 25, 2023
Merged

fix #18 export Mutators type declaration #20

merged 1 commit into from
Feb 25, 2023

Conversation

bentorkington
Copy link
Contributor

No description provided.

@maetl
Copy link
Collaborator

maetl commented Feb 25, 2023

We need to export usable TypeScript definitions from this lib at some point. I have gone through this process with the Rung lib on NPM and it seemed to work okay without porting the entire project to TypeScript.

I also suspect that some of the older dynamic programming stuff here (like this example of the mutator mixin) might need to change a bit. This library was very much designed in my head as an ideal modular trait-based API, but in the conversion to JS it ended up somewhere a bit different than what I wanted.

@maetl maetl merged commit 384448f into main Feb 25, 2023
@maetl maetl deleted the export-mutators branch February 25, 2023 04:17
@maetl
Copy link
Collaborator

maetl commented Feb 25, 2023

v0.12 on NPM has these changes incorporated into the types exports. As I said, I’m not 100% sure how usable these are and it would probably be good to deal with the issues identified in #17 to get this all sorted before adding any new features here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants