Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/zh cli #204

Merged
merged 17 commits into from
Jan 13, 2025
Merged

Feat/zh cli #204

merged 17 commits into from
Jan 13, 2025

Conversation

snadrus
Copy link
Contributor

@snadrus snadrus commented Sep 19, 2024

The CLI should speak zh & ko.
ZH doc images also fixed

SPTool zh in docs only, as most of the binary definition is in Lotus.

@snadrus snadrus requested a review from LexLuthr September 19, 2024 15:01
@LexLuthr
Copy link
Contributor

This PR seems to be pulling in some changes already merged in main

@snadrus snadrus marked this pull request as ready for review September 24, 2024 04:05
Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some Makefile changes to generate translated config, commands using make gen?

documentation/zh/.gitbook/assets/replaceTranslations.go Outdated Show resolved Hide resolved
@snadrus snadrus enabled auto-merge (squash) October 11, 2024 23:46
@snadrus
Copy link
Contributor Author

snadrus commented Oct 11, 2024

Can we add some Makefile changes to generate translated config, commands using make gen?

I cannot. I didn't use that process to make these translations.

@snadrus
Copy link
Contributor Author

snadrus commented Oct 11, 2024

@LexLuthr i don't know why gen fails. I ran it. Any idea?

@LexLuthr LexLuthr requested a review from magik6k January 13, 2025 12:47
@LexLuthr LexLuthr disabled auto-merge January 13, 2025 12:47
@snadrus snadrus enabled auto-merge (squash) January 13, 2025 15:27
@snadrus
Copy link
Contributor Author

snadrus commented Jan 13, 2025

Looks good @LexLuthr , but I need YOU to approve it since it's my PR. I enabled auto-merge for after your approval.

@snadrus snadrus merged commit 1418afb into main Jan 13, 2025
33 checks passed
@snadrus snadrus deleted the feat/zh-cli branch January 13, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants