feat: add support for optional parameters #106
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any nullable parameter is now optional.
|
Thoughts @fridrik01 @magik6k? |
magik6k
reviewed
Nov 29, 2023
There was a problem hiding this comment.
- Not a bad idea
- Not sure if we want this to be implicit for all handlers, it's not obvious that this is the behavior of this library
- Would be nice to have a more explicit way to tag args as optional
- This would allow non-pointer args (like TipSetKey in lotus) to become optional, which would be extremely convenient in some cases
- a generic
jsonrpc.Optional[T]wrapper? jsonrpc.OptionalArginterface?
| hasRawParams = true | ||
| } | ||
| recvs[i] = method.Type.In(i + 1 + hasCtx) | ||
| if recvs[i].Kind() == reflect.Pointer { |
There was a problem hiding this comment.
This should only apply to trailing params - the opt couter should be reset on non pointer (non optional) args.
That's a really good idea. Although dealing with generics & reflection is going to be a bit tricky. |
|
Hey @Stebalien, was there any decision made on this feature? Will it be supported? Have you also considered supporting variadic params? |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any nullable parameter is now optional.
TODO: