Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: release branch deprecation notice update #755

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

BigLep
Copy link
Member

@BigLep BigLep commented Aug 15, 2024

This is some followup for #754 ultimately in support of filecoin-project/lotus#12374

I don't think the releases branch deprecation needs to be an alert as I assume most people reading the doc are newer users. We can also keep the layer of indirection so if we need new commands we change them one place.

@BigLep
Copy link
Member Author

BigLep commented Aug 15, 2024

@rjan90 : I had missed #754 . This would have been my feedback. Feel free to reject/close though.

@BigLep BigLep requested a review from rjan90 August 15, 2024 20:32
@BigLep BigLep self-assigned this Aug 15, 2024
@BigLep BigLep marked this pull request as ready for review August 15, 2024 20:34
@rjan90
Copy link
Collaborator

rjan90 commented Aug 15, 2024

Makes sense having it only in one place, and link to it elsewhere.

@BigLep BigLep merged commit 716f2d4 into main Aug 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants