docs: seed CONTRIBUTING.md with pr title and changelog expectations #12361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigLep
added
the
skip/changelog
GitHub Codespaces
This was referenced Aug 8, 2024
rjan90
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Fixed a couple of typos and replaced # with // for comments in the pr-title-check.yml file. The # comments were invalid in JavaScript, causing the check to fail.
After those has been applied, this PR should be fine to merge into the phi/PR-title-check branch, and then we can continue to land your suggestion: #12340
Co-authored-by: Phi-rjan <[email protected]>
Co-authored-by: Phi-rjan <[email protected]>
Co-authored-by: Phi-rjan <[email protected]>
Co-authored-by: Phi-rjan <[email protected]>
rjan90
added a commit
that referenced
this pull request
Aug 9, 2024
* Add PR title check workflow Add PR title check workflow Add colon Add colon Request change to PR title instead of blocking PR Request change to PR title instead of blocking PR Remove change requested if title conforms to the formate Remove change requested if title conforms to the formate * fix: workflow: Ensure PR title check posts review comments fix: workflow: Ensure PR title check posts review comments * Add fail if title is invalid Add fail if title is invalid * fix: workflow: Ensure PR title check fails for invalid titles fix: workflow: Ensure PR title check fails for invalid titles * refactor: pr-title-check: Streamline workflow and reduce complexity refactor: pr-title-check: Streamline workflow and reduce complexity * Update allowed PR-types pattern Update allowed PR-types pattern * Update pr-title-check.yml Co-authored-by: Rod Vagg <[email protected]> * Use conventional commit, but allow for legacy - Allow optional "[skip changelog]" prefix - Both <type>: <scope>: and <type>(<scope>): formats - Use conventional commit "scope" instead of area - Alphabetize <type> and <scope> * docs: update pull_request_template.md Adjust pull_request_template.md according to the changes introduced with the PR title check workflow * fix(ci): update regex to support both PR title formats fix(ci): update regex to support both PR title formats * docs: seed CONTRIBUTING.md with pr title and changelog expectations (#12361) This starts on #12360 as part of landing #12340 * Update .github/workflows/pr-title-check.yml Co-authored-by: Phi-rjan <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Phi-rjan <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Phi-rjan <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Phi-rjan <[email protected]> --------- Co-authored-by: Phi-rjan <[email protected]> * Update .github/workflows/pr-title-check.yml Co-authored-by: Steve Loeppky <[email protected]> --------- Co-authored-by: Rod Vagg <[email protected]> Co-authored-by: Steve Loeppky <[email protected]>
rjan90
added a commit
to hanabi1224/lotus
that referenced
this pull request
Aug 12, 2024
* Add PR title check workflow Add PR title check workflow Add colon Add colon Request change to PR title instead of blocking PR Request change to PR title instead of blocking PR Remove change requested if title conforms to the formate Remove change requested if title conforms to the formate * fix: workflow: Ensure PR title check posts review comments fix: workflow: Ensure PR title check posts review comments * Add fail if title is invalid Add fail if title is invalid * fix: workflow: Ensure PR title check fails for invalid titles fix: workflow: Ensure PR title check fails for invalid titles * refactor: pr-title-check: Streamline workflow and reduce complexity refactor: pr-title-check: Streamline workflow and reduce complexity * Update allowed PR-types pattern Update allowed PR-types pattern * Update pr-title-check.yml Co-authored-by: Rod Vagg <[email protected]> * Use conventional commit, but allow for legacy - Allow optional "[skip changelog]" prefix - Both <type>: <scope>: and <type>(<scope>): formats - Use conventional commit "scope" instead of area - Alphabetize <type> and <scope> * docs: update pull_request_template.md Adjust pull_request_template.md according to the changes introduced with the PR title check workflow * fix(ci): update regex to support both PR title formats fix(ci): update regex to support both PR title formats * docs: seed CONTRIBUTING.md with pr title and changelog expectations (filecoin-project#12361) This starts on filecoin-project#12360 as part of landing filecoin-project#12340 * Update .github/workflows/pr-title-check.yml Co-authored-by: Phi-rjan <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Phi-rjan <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Phi-rjan <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Phi-rjan <[email protected]> --------- Co-authored-by: Phi-rjan <[email protected]> * Update .github/workflows/pr-title-check.yml Co-authored-by: Steve Loeppky <[email protected]> --------- Co-authored-by: Rod Vagg <[email protected]> Co-authored-by: Steve Loeppky <[email protected]>
rjan90
added a commit
that referenced
this pull request
Aug 12, 2024
* Add PR title check workflow Add PR title check workflow Add colon Add colon Request change to PR title instead of blocking PR Request change to PR title instead of blocking PR Remove change requested if title conforms to the formate Remove change requested if title conforms to the formate * fix: workflow: Ensure PR title check posts review comments fix: workflow: Ensure PR title check posts review comments * Add fail if title is invalid Add fail if title is invalid * fix: workflow: Ensure PR title check fails for invalid titles fix: workflow: Ensure PR title check fails for invalid titles * refactor: pr-title-check: Streamline workflow and reduce complexity refactor: pr-title-check: Streamline workflow and reduce complexity * Update allowed PR-types pattern Update allowed PR-types pattern * Update pr-title-check.yml Co-authored-by: Rod Vagg <[email protected]> * Use conventional commit, but allow for legacy - Allow optional "[skip changelog]" prefix - Both <type>: <scope>: and <type>(<scope>): formats - Use conventional commit "scope" instead of area - Alphabetize <type> and <scope> * docs: update pull_request_template.md Adjust pull_request_template.md according to the changes introduced with the PR title check workflow * fix(ci): update regex to support both PR title formats fix(ci): update regex to support both PR title formats * docs: seed CONTRIBUTING.md with pr title and changelog expectations (#12361) This starts on #12360 as part of landing #12340 * Update .github/workflows/pr-title-check.yml Co-authored-by: Phi-rjan <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Phi-rjan <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Phi-rjan <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Phi-rjan <[email protected]> --------- Co-authored-by: Phi-rjan <[email protected]> * Update .github/workflows/pr-title-check.yml Co-authored-by: Steve Loeppky <[email protected]> --------- Co-authored-by: Rod Vagg <[email protected]> Co-authored-by: Steve Loeppky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts on #12360 as part of landing #12340