[skip changelog] feat(f3): move F3 pubsub topics to F3 module #12383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
steb/pluggable-pubsub-topics
branch
3 times, most recently
from
cc1906a to
42b6bd9
Compare
Stebalien
commented
Aug 14, 2024
| allowTopics = append(allowTopics, f3TopicName+"/"+fmt.Sprintf("%d", i)) | ||
| } | ||
| } | ||
| build.F3TopicName(in.Nn), |
There was a problem hiding this comment.
Always enabled. The filter exists to protect against a DoS attack with too many topic names, adding a single one won't make a difference.
| @@ -163,7 +163,8 @@ var ChainNode = Options( | |||
| ), | |||
|
|
|||
| If(build.IsF3Enabled(), | |||
| Override(new(manifest.ManifestProvider), lf3.NewManifestProvider), | |||
| Override(new(*manifest.Manifest), lf3.NewManifest), | |||
There was a problem hiding this comment.
This will make it easier to override the manifest while testing without changing everything.
node/builder.go
Outdated
| BandwidthReporterKey = special{11} // Libp2p option | ||
| ConnGaterKey = special{12} // Libp2p option | ||
| ResourceManagerKey = special{14} // Libp2p option | ||
| F3ManifestProviderKey = special{15} // F3 Manifest Provider |
There was a problem hiding this comment.
Added this here because the new manifest provider optionally returns a list of pubsub topics.
Stebalien
force-pushed
the
steb/pluggable-pubsub-topics
branch
from
42b6bd9 to
2039cd6
Compare
This way, we don't have to rely on a global variable to determine if F3 is enabled, which will make testing easier. Pre-requisite for #12204
|
Ah, lovely. It's a DI cycle. |
|
Closed because this has to be re-done from scratch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Pre-requisite for #12204
Proposed Changes
Move F3 pubsub topics to F3 module. This way, we don't have to rely on a global variable to determine if F3 is enabled, which will make testing easier. Instead, we can provide the pubsub topics when we provide the F3 manifest provider and service.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that: