Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: itests: cleanup parts forgotten in #12407 #12427

Merged
merged 1 commit into from
Sep 5, 2024
Merged

chore: itests: cleanup parts forgotten in #12407 #12427

merged 1 commit into from
Sep 5, 2024

Conversation

ribasushi
Copy link
Collaborator

Related Issues

#12407

@ribasushi ribasushi marked this pull request as ready for review September 3, 2024 11:00
@ribasushi ribasushi changed the title chore: itests: cleanup parts forgotten in #12407 [skip changelog] chore: itests: cleanup parts forgotten in #12407 Sep 3, 2024
@rjan90
Copy link
Contributor

rjan90 commented Sep 3, 2024

Thanks for catching more of these HarmonDB-itest parts. To me the changes look okay, but would like @LexLuthr or @snadrus to give a ✅

@rjan90 rjan90 requested review from snadrus and LexLuthr September 3, 2024 11:05
@rjan90 rjan90 added the skip/changelog This change does not require CHANGELOG.md update label Sep 5, 2024
@rjan90 rjan90 changed the title [skip changelog] chore: itests: cleanup parts forgotten in #12407 chore: itests: cleanup parts forgotten in #12407 Sep 5, 2024
@rjan90 rjan90 merged commit 6753885 into filecoin-project:master Sep 5, 2024
87 of 88 checks passed
@ribasushi ribasushi deleted the chore/janitorial branch September 5, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@snadrus snadrus Awaiting requested review from snadrus

@LexLuthr LexLuthr Awaiting requested review from LexLuthr

Assignees
No one assigned
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ribasushi @rjan90 @magik6k