Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hanabi1224 upgrade deps #1770

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Hanabi1224 upgrade deps #1770

wants to merge 7 commits into from

Conversation

cryptonemo
Copy link
Collaborator

This is a replacement of #1767 (PR moved to this repo)

fix: all required clippy updates
@cryptonemo
Copy link
Collaborator Author

This PR also replaces #1768 and #1769

@cryptonemo
Copy link
Collaborator Author

Looks like the MacOS runners are broken (failure to download parameters). I may disable that as required for now, but if someone wants to take a look at what could get them going again, please do

@vmx
Copy link
Contributor

vmx commented Jan 7, 2025

I may disable that as required for now, but if someone wants to take a look at what could get them going again, please do

Marking them as non required is a good idea (I would mark none of the tests as required, in the past it's been causing more issues than good). Once this PR lands, I will retrigger the parameter generation job, which should then make the MacOS ones work again.

build.rs Outdated Show resolved Hide resolved
fr32/src/padding.rs Outdated Show resolved Hide resolved
fr32/src/padding.rs Outdated Show resolved Hide resolved
storage-proofs-core/src/gadgets/insertion.rs Outdated Show resolved Hide resolved
storage-proofs-porep/build.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants