Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid race condition on conditional variable #602

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Avoid race condition on conditional variable #602

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
221c1f0
Avoid race condition on conditional variable
kushalbabel Apr 10, 2024
9a68096
read the atomic counter again after waking up on cond var
kushalbabel Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion services/api/blocksim_ratelimiter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,9 @@ func NewBlockSimulationRateLimiter(blockSimURL string) *BlockSimulationRateLimit
func (b *BlockSimulationRateLimiter) Send(context context.Context, payload *common.BuilderBlockValidationRequest, isHighPrio, fastTrack bool) (requestErr, validationErr error) {
b.cv.L.Lock()
cnt := atomic.AddInt64(&b.counter, 1)
if maxConcurrentBlocks > 0 && cnt > maxConcurrentBlocks {
for maxConcurrentBlocks > 0 && cnt > maxConcurrentBlocks {
b.cv.Wait()
cnt = atomic.LoadInt64(&b.counter)
}
b.cv.L.Unlock()

Expand Down
Loading