feat: add csv data source #54
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertmiller
requested review from
dvush,
ZanCorDX,
metachris and
jakubhruby7
as code owners
Benchmark results for
|
| Date (UTC) | 2024-07-13T11:11:36+00:00 |
| Commit | 6b219c85845d6d99c7e91391feb50f48973998b2 |
| Base SHA | db634fcb90a6b2fc484e19f02a59a5b74ffeefa2 |
Significant changes
None
1 task
ZanCorDX
reviewed
Jul 15, 2024
| ) -> Order { | ||
| let uuid_bytes = uuid_num.to_be_bytes(); | ||
| let tx_with_blobs = TransactionSignedEcRecoveredWithBlobs::new_no_blobs(tx).unwrap(); | ||
| let bundle = Bundle { |
There was a problem hiding this comment.
Bundle creation is tricky (didn't have time to correct it :().
You should create it with a dummy hash/uuid (Default::default()) and then call hash_slow().
ZanCorDX
reviewed
Jul 15, 2024
| // The csv datasource is one with 10 batches, where batch is a list of transactions | ||
| // Since we don't have full "real" blocks, we'll just use the block number to determine the batch | ||
| // Thus the usage of mod 10 is just to determine the batch number that we get transactions from, e.g. block 100 corresponds to 0, 101 to 1, 109 to 9, etc. | ||
| let batch_number = block.block_number % 10; |
There was a problem hiding this comment.
this 10 should be a constant.
Maybe also some function like batch_number_from_u64() to isolate the % 10?
ZanCorDX
reviewed
Jul 15, 2024
| let mut reader = Reader::from_reader(file); | ||
| let mut batches: HashMap<u64, Vec<TransactionSignedEcRecovered>> = HashMap::new(); | ||
|
|
||
| for result in reader.records() { |
ZanCorDX
reviewed
Jul 15, 2024
|
|
||
| for result in reader.records() { | ||
| let record = result?; | ||
| if record.len() != 2 { |
There was a problem hiding this comment.
0,1,and 2 could be constants also documenting the format
eg:
/// col 1 contains bla bla
const COL_RAW_RLP_RX = 1
Is col 0 an arbitrary number? Is this some block number?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Adds the ability to load orders from a csv
💡 Motivation and Context
For backtesting bundles
✅ I have completed the following steps:
make lintmake test