Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure formatting tools #502

Merged
merged 5 commits into from
Nov 10, 2023

Conversation

a2937
Copy link
Member

@a2937 a2937 commented Nov 8, 2023

Checklist:

Closes #497

This adds a husky pre-commit hook and automatically lints all committed files with lint-staged.

@a2937 a2937 requested a review from a team as a code owner November 8, 2023 16:15
Copy link

socket-security bot commented Nov 8, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
husky 8.0.0 environment +0 6.38 kB typicode
lint-staged 15.0.2 environment +35 2.03 MB okonet

@raisedadead
Copy link
Member

raisedadead commented Nov 9, 2023

I believe, we need to run prettier on all the files at least once before we merge this. No? Also @a2937 are you on our discord chat by any chance?

@naomi-lgbt
Copy link
Member

I believe, we need to run prettier on all the files at least once before we merge this. No?

Not necessarily. We could do that in a follow-up PR if we wanted.

@a2937
Copy link
Member Author

a2937 commented Nov 9, 2023

I believe, we need to run prettier on all the files at least once before we merge this. No? Also @a2937 are you on our discord chat by any chance?

Yes I am in the discord chat. And I can try running it for sure.

@a2937 a2937 force-pushed the feat/formatting-tools branch from 7fd7918 to 9de3a35 Compare November 9, 2023 18:35
@a2937
Copy link
Member Author

a2937 commented Nov 9, 2023

Because there are literally 210 files that get reformatted, even after I create a .prettierignore file, running prettier on the project should be held off until it can be done in a followup PR.

@raisedadead raisedadead merged commit 4797396 into freeCodeCamp:main Nov 10, 2023
3 checks passed
@a2937 a2937 deleted the feat/formatting-tools branch November 10, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure Prettier, ESLint and Formatting Tools
3 participants