Cc/test/6/pin elixir version to last known good #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Match the .tool-versions Elixir version to what is already in the mix.exs file (Elixir 1.10). Add corresponding Erlang OTP version. Add a reasonable Java runtime for the PlantUML tasks to pass muster. This will be especially helpful to those of us who have not kept in touch with recent developments in the Java world.
Communicate the current sensitivity to Elixir versions so people better understand errors they may see.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, first, I appreciate your work on this project! I was starting down a related path, so I was grateful to find your project.
Adding the package to a project revealed some sensitivities to specific versions of Elixir. I confirmed this by running the test suite and noticing issue #6 as well.
This simple PR adds the version info necessary for users of
asdfto successfully run the test suite.My goal with this PR was to establish a working baseline with all tests passing, so that I could then bump to a newer version of Elixir and hopefully help get the project working for those too.