Flush the merge-wait queue on SIGUSR2 #1406
Open
+19
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If portage receives SIGUSR2, then flush the merge-wait queue on the next possible occasion (typically after all running "install" jobs are finished). Signed-off-by: Florian Schmaus <[email protected]>
zmedico
approved these changes
Dec 28, 2024
thesamesam
reviewed
Dec 28, 2024
| @@ -1193,6 +1199,10 @@ def sighandler(signum, frame): | |||
| signal.signal(signal.SIGCONT, earlier_sigcont_handler) | |||
| else: | |||
| signal.signal(signal.SIGCONT, signal.SIG_DFL) | |||
| if earlier_sigusr2_handler is not None: | |||
There was a problem hiding this comment.
No need to do this now, but I wonder if we could do bette rwith this with a context manager.
There was a problem hiding this comment.
This would require creating a custom context manager class for signals, right?
thesamesam
reviewed
Dec 28, 2024
| self._merge_wait_queue | ||
| and not self._jobs | ||
| and not self._task_queues.merge | ||
| if self._merge_wait_queue and ( |
There was a problem hiding this comment.
This might be nice as a variable instead.
There was a problem hiding this comment.
Not sure if I understand. "This" being _merge_wait_queue and you want something like merge_wait_queue_not_empty?
thesamesam
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If portage receives SIGUSR2, then flush the merge-wait queue on the next possible occasion (typically after all running "install" jobs are finished).