Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add mechanism to ANR event #1955

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

bitsandfoxes
Copy link
Contributor

Addresses the improvement part of #1954

In line with Java and the V1 ANR watchdog (documented here), the SDK will now add the ANR mechanism when capturing an ANR event.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Add mechanism to ANR event ([#1955](https://github.com/getsentry/sentry-unity/pull/1955))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 43c1a29

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests

OnApplicationNotResponding?.Invoke(this, new ApplicationNotRespondingException(message));

var exception = new ApplicationNotRespondingException(message);
exception.SetSentryMechanism("ANR", handled: false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could benefit some description. E.g: "doesn't crash the app"
I suggested that here: #1954

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! Thanks Stefan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants