-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add mechanism to ANR event #1955
base: main
Are you sure you want to change the base?
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Add mechanism to ANR event ([#1955](https://github.com/getsentry/sentry-unity/pull/1955)) If none of the above apply, you can opt out of this check by adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing tests
OnApplicationNotResponding?.Invoke(this, new ApplicationNotRespondingException(message)); | ||
|
||
var exception = new ApplicationNotRespondingException(message); | ||
exception.SetSentryMechanism("ANR", handled: false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could benefit some description. E.g: "doesn't crash the app"
I suggested that here: #1954
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! Thanks Stefan
Addresses the improvement part of #1954
In line with Java and the V1 ANR watchdog (documented here), the SDK will now add the
ANR
mechanism when capturing an ANR event.