feat(metric-issues): Add lastChecked to OpenPeriod #83970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
snigdhas
force-pushed
the
snigdha/last-seen-fe
branch
from
95fbcf2 to
d2e4695
Compare
| @@ -849,6 +849,7 @@ export interface GroupOpenPeriod { | |||
| end: string; | |||
| isOpen: boolean; | |||
| start: string; | |||
| lastChecked?: string; | |||
There was a problem hiding this comment.
should this be optional? if not, maybe string | null would be a better match for the backend type
There was a problem hiding this comment.
updating the backend PR - it shouldn't ever be null in theory. I'm marking it optional for now while we add the field and will change to required after the PRs land.
roggenkemper
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the new field to the GroupOpenPeriod definition. The backend change that adds this field is #83969