chore(github): Remove debugging code #83986
Open
+2
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was added in order to investigate an edge case. When an organization has less repositories than the max number of the page, it would not add a `Link` header. In other words, we only see when a GitHub org has less than 100 repositories.
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Jan 24, 2025
| @@ -504,8 +504,6 @@ def get_repos(self, fetch_max_pages: bool = False) -> list[dict[str, Any]]: | |||
| It uses page_size from the base class to specify how many items per page. | |||
| The upper bound of requests is controlled with self.page_number_limit to prevent infinite requests. | |||
| """ | |||
| # XXX: In order to speed up this function we could use ThreadPoolExecutor | |||
| # to fetch repositories in parallel. See src/sentry/utils/snuba.py | |||
There was a problem hiding this comment.
This is already mentioned inside of get_with_pagination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was added to investigate an edge case.
An organization with fewer repositories than the maximum page number would not add a
Linkheader. In other words, we only see when a GitHub org has less than 100 repositories.Fixes SENTRY-3M8Z