Use Update After Bind Descriptors for Bind Groups With Binding Arrays #6815
+119
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
cwfitzgerald
force-pushed
the
cw/use-update-after-bind-for-binding-arrays
branch
5 times, most recently
from
88b1ce1 to
78549c4
Compare
Update After Bind x
cwfitzgerald
force-pushed
the
cw/use-update-after-bind-for-binding-arrays
branch
from
78549c4 to
56d33e8
Compare
|
This PR is a bit of a mess, but I think it's broadly correct and the following PRs will further refine feature specifics. Specifically, we're moving towards two features for bindless, not many. One for "Baseline Bindless" which gets you non-uniform indexing of Storage Textures, Storage Buffers, and Sampled Textures. Then one feature for non-uniform indexing of uniform buffers, if people end up wanting that. |
magcius
reviewed
Jan 24, 2025
| F::TEXTURE_BINDING_ARRAY, | ||
| self.core.shader_sampled_image_array_dynamic_indexing != 0, | ||
| ); | ||
| features.set(F::SHADER_PRIMITIVE_INDEX, self.core.geometry_shader != 0); |
There was a problem hiding this comment.
Is it intentional that support for SHADER_PRIMITIVE_INDEX appears dropped here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6737
Closes #6606