Lexer for Inform 7 #1727
Lexer for Inform 7 #1727
Conversation
| @@ -278,7 +278,9 @@ https://github.com/textmate/haskell.tmbundle: | |||
| https://github.com/textmate/html.tmbundle: | |||
| - text.html.basic | |||
| https://github.com/textmate/inform.tmbundle: | |||
| - source.inform | |||
| - source.inform6 | |||
There was a problem hiding this comment.
Unfortunately just changing the scope name here won't work. script/download-grammars regenerates this file when it runs and will undo this change. (In fact, the best way to add new grammars to this file is to run script/download-grammars --add https://github.com/PogiNate/Sublime-Inform.)
And if we aren't using this grammar anymore we should just remove it.
There was a problem hiding this comment.
Rather than remove it, I suggest adding an entry for Inform 6 to languages.yml.
|
Thanks for getting this started @pchaigno, and especially for filing that issue about the license! |
|
@aroben Thanks for the review! |
Definitely! |
| @@ -1135,7 +1135,7 @@ Inform 7: | |||
| extensions: | |||
| - .ni | |||
| - .i7x | |||
| tm_scope: source.inform | |||
| tm_scope: source.inform7 | |||
There was a problem hiding this comment.
I think we'll need to say source.Inform7 here to match the case used in Sublime-Inform itself.
Running script/prune-grammars should also remove the old inform grammar (after verifying that it's no longer used).
There was a problem hiding this comment.
Done. We should probably have some test of the tm_scope too.
I couldn't run script/prune-grammars (still trying to see why) so I verified manually that it wasn't used anymore.
|
@dscorbett I removed the grammar for Inform 6. I couldn't find a lot of Inform 6 files on GitHub (I may not be using the right keywords). If you want to add it, please open an issue with examples of Inform 6 on GitHub, a search result page would be better (we try to only add new languages once they have some usage on GitHub). |
|
Sublime-Inform is now distributed under the MIT license! |
|
Thanks, this looks great! Did you figure out why |
|
@aroben Nope, I haven't have time to look at it yet. I'll open an issue if I can't figure out what I'm doing wrong. |
This pull request adds a lexer for Inform 7 as requested in #1725.
The lexer is at: https://github.com/PogiNate/Sublime-Inform.
I opened an issue on the repository to clarify the license situation: PogiNate/Sublime-Inform#2.