Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: update rust-analyzer #18443

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Rust: update rust-analyzer #18443

wants to merge 4 commits into from

Conversation

redsun82
Copy link
Contributor

@redsun82 redsun82 commented Jan 8, 2025

This is the result of

  • running the upgrade from cargo-edit:
    cargo upgrade --incompatible --pinned
    rust/update_cargo_deps.sh
  • Fixing code incompatibilities
  • Removing patching of rust.ungram (as the change was done upstream)
  • Updating the rust-analyzer source download done for ast-generator
  • Fixing file_to_module_def not working any more on Windows, by using to_def on the ast source file instead

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Jan 8, 2025
@redsun82 redsun82 force-pushed the redsun82/cargo-upgrade branch from 09f1027 to c7a9889 Compare January 8, 2025 10:14
Paolo Tranquilli added 3 commits January 8, 2025 17:11
For some reason `file_to_module_def` was not working any more on
windows. This achieves the same functionality by checking a definition
for the source file later on.
@redsun82 redsun82 marked this pull request as ready for review January 8, 2025 16:24
@Copilot Copilot bot review requested due to automatic review settings January 8, 2025 16:24
@redsun82 redsun82 requested a review from a team as a code owner January 8, 2025 16:24

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 30 out of 50 changed files in this pull request and generated no comments.

Files not reviewed (20)
  • MODULE.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra-ap-rustc_abi-0.87.0.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra-ap-rustc_index-0.87.0.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra-ap-rustc_index_macros-0.87.0.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra-ap-rustc_lexer-0.87.0.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra-ap-rustc_parse_format-0.87.0.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra-ap-rustc_pattern_analysis-0.87.0.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra_ap_base_db-0.0.257.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra_ap_cfg-0.0.257.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra_ap_edition-0.0.257.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra_ap_hir-0.0.257.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra_ap_hir_def-0.0.257.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra_ap_hir_expand-0.0.257.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra_ap_hir_ty-0.0.257.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra_ap_ide_db-0.0.257.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra_ap_intern-0.0.257.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra_ap_limit-0.0.257.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra_ap_load-cargo-0.0.257.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.ra_ap_mbe-0.0.257.bazel: Language not supported

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@redsun82 redsun82 marked this pull request as draft January 8, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant