Rust: Include index in Format.getArgument
#18445
Open
+90
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
rust/format-args-index
branch
from
198d94b to
033cd17
Compare
hvitved
force-pushed
the
rust/format-args-index
branch
from
6cb3ef0 to
0dccbb9
Compare
There was a problem hiding this comment.
Copilot reviewed 7 out of 13 changed files in this pull request and generated no comments.
Files not reviewed (6)
- rust/ql/.generated.list: Language not supported
- rust/ql/lib/codeql/rust/AstConsistency.qll: Language not supported
- rust/ql/lib/codeql/rust/controlflow/CfgNodes.qll: Language not supported
- rust/ql/lib/codeql/rust/elements/internal/FormatArgumentImpl.qll: Language not supported
- rust/ql/lib/codeql/rust/elements/internal/FormatImpl.qll: Language not supported
- rust/ql/test/query-tests/diagnostics/AstConsistencyCounts.expected: Language not supported
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
Formatcan have multipleFormatArguments, sogetArgumentmust take an index. I have added two new consistency checks as well, one of which (multipleChildren) would fail prior to this PR.