Merge pull request #214 from github/add-jsx-intrinsicelement-types

add JSX IntrinsicElement types
github · Nov 28, 2022 · f35461a · f35461a
2 parents 223bc5d + b66d687
commit f35461a
Show file tree

Hide file tree

Showing 5 changed files with 38 additions and 0 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -6,6 +6,12 @@
     "import/no-unresolved": "off"
   },
   "overrides": [
+    {
+      "files": "src/*-define.ts",
+      "rules": {
+        "@typescript-eslint/no-namespace": "off"
+      }
+    },
     {
       "files": "test/**/*.js",
       "rules": {

diff --git a/src/local-time-element-define.ts b/src/local-time-element-define.ts
@@ -13,13 +13,21 @@ try {
   }
 }
 
+type JSXBaseElement = JSX.IntrinsicElements extends {span: unknown}
+  ? JSX.IntrinsicElements['span']
+  : Record<string, unknown>
 declare global {
   interface Window {
     LocalTimeElement: typeof LocalTimeElement
   }
   interface HTMLElementTagNameMap {
     'local-time': LocalTimeElement
   }
+  namespace JSX {
+    interface IntrinsicElements {
+      ['local-time']: JSXBaseElement & Partial<Omit<LocalTimeElement, keyof HTMLElement>>
+    }
+  }
 }
 
 export default LocalTimeElement

diff --git a/src/relative-time-element-define.ts b/src/relative-time-element-define.ts
@@ -13,13 +13,21 @@ try {
   }
 }
 
+type JSXBaseElement = JSX.IntrinsicElements extends {span: unknown}
+  ? JSX.IntrinsicElements['span']
+  : Record<string, unknown>
 declare global {
   interface Window {
     RelativeTimeElement: typeof RelativeTimeElement
   }
   interface HTMLElementTagNameMap {
     'relative-time': RelativeTimeElement
   }
+  namespace JSX {
+    interface IntrinsicElements {
+      ['relative-time']: JSXBaseElement & Partial<Omit<RelativeTimeElement, keyof HTMLElement>>
+    }
+  }
 }
 
 export default RelativeTimeElement

diff --git a/src/time-ago-element-define.ts b/src/time-ago-element-define.ts
@@ -13,13 +13,21 @@ try {
   }
 }
 
+type JSXBaseElement = JSX.IntrinsicElements extends {span: unknown}
+  ? JSX.IntrinsicElements['span']
+  : Record<string, unknown>
 declare global {
   interface Window {
     TimeAgoElement: typeof TimeAgoElement
   }
   interface HTMLElementTagNameMap {
     'time-ago': TimeAgoElement
   }
+  namespace JSX {
+    interface IntrinsicElements {
+      ['time-ago']: JSXBaseElement & Partial<Omit<TimeAgoElement, keyof HTMLElement>>
+    }
+  }
 }
 
 export default TimeAgoElement

diff --git a/src/time-until-element-define.ts b/src/time-until-element-define.ts
@@ -13,13 +13,21 @@ try {
   }
 }
 
+type JSXBaseElement = JSX.IntrinsicElements extends {span: unknown}
+  ? JSX.IntrinsicElements['span']
+  : Record<string, unknown>
 declare global {
   interface Window {
     TimeUntilElement: typeof TimeUntilElement
   }
   interface HTMLElementTagNameMap {
     'time-until': TimeUntilElement
   }
+  namespace JSX {
+    interface IntrinsicElements {
+      ['time-until']: JSXBaseElement & Partial<Omit<TimeUntilElement, keyof HTMLElement>>
+    }
+  }
 }
 
 export default TimeUntilElement