Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create official helm chart for safe-settings #580

Merged
merged 8 commits into from
Mar 31, 2024
Merged

Create official helm chart for safe-settings #580

merged 8 commits into from
Mar 31, 2024

Conversation

NissesSenap
Copy link
Contributor

This helm chart has taken much inspiration from https://github.com/decyjphr-org/charts/tree/main/helm-charts/safe-settings, but it differs in one main way. It don't force the user to put any secrets directly in the values files. Instead, I make it possible to either set the environment variables or point to any Kubernetes secret you want. I assume that the secret already exists, how this secret is up to the user of the helm chart.

In a GitOps world, I would suggest something like

  • sealed secrets
  • external-secrets
  • etc.

Or if you want, you can still add the secret through Kubernetes.

This of course makes it harder to use the helm chart, but it will help to enforce best practices. We can of course extend this PR to support a similar Kubernetes secret injection that the current helm chart supports. But it needs to be able to disable this feature.

I have created a helm chart so you can try it out if you want helm upgrade -i safe-settings oci://ghcr.io/nissessenap/helm-charts/safe-settings --version 2.1.0

TODO

Partly fixes #578

Looking forward to your feedback.

@NissesSenap
Copy link
Contributor Author

Should be able to use /probot and health endpoint

@decyjphr
Copy link
Collaborator

Thanks @NissesSenap I'll do a test deploy and then merge. Awesome that we will have a helm chart that is kinda official.

@decyjphr decyjphr merged commit 9128ea8 into github:main-enterprise Mar 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create official helm chart
2 participants