-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Express version information in decimal #721
Conversation
Signed-off-by: Clayton Smith <[email protected]>
Before:
After:
|
GNSS-SDR is the one other user of VOLK that I know of, and it doesn't use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do this, before the current state causes any more damage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
That will continue working, for the same reason that GNU Radio's checks will. Future decimal versions numbers will be greater than 0301008. |
Express version information in decimal
Fixes #720.
VOLK's version header (created in #346) unintentionally expresses version numbers in octal, because it prefixes the (decimal) numbers with zeroes. This will fail (with
error: invalid digit "8" in octal constant
) as soon as any component of the version number reaches 8.The documentation in the header states that
VOLK_VERSION
is decimal, and this is a more convenient format, so I think it makes sense to switch to that. GNU radio already uses#if VOLK_VERSION >= 030100
, but this condition will continue to be true if VOLK switches to decimal because 3010010 is greater than 0301008 (= 1235210).I considered instead changing the header documentation to indicate that the format is octal, but it would be difficult to implement correct header generation in CMake, because CMake's
math
only supports decimal and hexadecimal output formats.