Remove unnecessary volatiles from volk_32fc_s32f_magnitude_16i #724
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several variables in
volk_32fc_s32f_magnitude_16i
were marked as volatile in an attempt to resolve a flaky test:#282 (comment)
#282 (comment)
#285
These changes did not actually resolve the flaky test; it still failed on i386, and the test itself was later fixed in #713. Therefore, we can now revert the additions of
volatile
that were made in #285.