Remove SSE protokernels written in assembly #725
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only three protokernels remain that are written entirely in assembly:
volk_32fc_x2_conjugate_dot_prod_32fc_a_sse
volk_32fc_x2_dot_prod_32fc_u_sse_64
volk_32fc_x2_dot_prod_32fc_a_sse_64
These are holdovers from the early days of GNU Radio, and I don't think keeping them is worth the maintenance cost. Both
volk_32fc_x2_conjugate_dot_prod_32fc
andvolk_32fc_x2_dot_prod_32fc
have SSE3 protokernels which perform better, and SSE3 has been around since 2004.