Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SSE protokernels written in assembly #725

Merged
merged 1 commit into from
Dec 17, 2023

Conversation

argilo
Copy link
Member

@argilo argilo commented Dec 15, 2023

Only three protokernels remain that are written entirely in assembly:

  • volk_32fc_x2_conjugate_dot_prod_32fc_a_sse
  • volk_32fc_x2_dot_prod_32fc_u_sse_64
  • volk_32fc_x2_dot_prod_32fc_a_sse_64

These are holdovers from the early days of GNU Radio, and I don't think keeping them is worth the maintenance cost. Both volk_32fc_x2_conjugate_dot_prod_32fc and volk_32fc_x2_dot_prod_32fc have SSE3 protokernels which perform better, and SSE3 has been around since 2004.

Copy link
Contributor

@jdemel jdemel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we discussed expected CPU features lately. In essence, 32bit x86 is probably hard to find nowadays. It's reasonable to remove the maintenance burden here.
64bit x86 requires at least SSE2. A fact that caused issues in the past as well.

@jdemel jdemel merged commit eed16da into gnuradio:main Dec 17, 2023
32 checks passed
Alesha72003 pushed a commit to Alesha72003/volk that referenced this pull request May 15, 2024
Remove SSE protokernels written in assembly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants