cmake: Switch to GNUInstallDirs #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The custom code to determine `lib` vs `lib64` folder names on different distros was error prone. There's a better tool for that. Let's use it and potentially fix more issues that arise. Signed-off-by: Johannes Demel <[email protected]>
|
I tested this with PyBOMBS and it works fine there. |
|
All tests pass. It's a little change. Let's merge it. |
|
I just cloned the 'main' branch, built, and installed volk here on Fedora Core, and this time the shared libraries and related files get correctly installed in the right place ('/usr/local/lib64'): Thanks for fixing it! |
Alesha72003
pushed a commit
to Alesha72003/volk
that referenced
this pull request
May 15, 2024
cmake: Switch to GNUInstallDirs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom code to determine
libvslib64folder names on different distros was error prone. There's a better tool for that. Let's use it and potentially fix more issues that arise.Fixes #723