Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fprintf: Remove fprintf statements from volk_malloc #744

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

jdemel
Copy link
Contributor

@jdemel jdemel commented Jan 12, 2024

As per issue description, this may fail and is communicated the C way via a NULL pointer. As with similar routines, a user must check the return value. We shouldn't clutter stderr.

Fixes #666

Given the number of the issue, I need to point out that there is a great song about it by Iron Maiden

As per issue description, this may fail and is communicated the C way
via a `NULL` pointer. As with similar routines, a user must check the
return value. We shouldn't clutter stderr.

Signed-off-by: Johannes Demel <[email protected]>
@jdemel jdemel requested a review from marcusmueller January 12, 2024 22:18
@jdemel jdemel merged commit f751a54 into gnuradio:main Jan 29, 2024
33 checks passed
@jdemel jdemel deleted the remove-fprintf-from-volk-malloc branch January 29, 2024 21:31
Alesha72003 pushed a commit to Alesha72003/volk that referenced this pull request May 15, 2024
…malloc

fprintf: Remove fprintf statements from volk_malloc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

volk_malloc should not printf
2 participants