Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove volk_16u_byteswap_a_orc #747

Closed
wants to merge 1 commit into from

Conversation

argilo
Copy link
Member

@argilo argilo commented Jan 30, 2024

This protokernel was enabled in #719, but it appears to be broken on M1, so let's remove it for now.

Fixes #745.

It appears to be broken on M1, so let's remove it for now.

Signed-off-by: Clayton Smith <[email protected]>
@jdemel
Copy link
Contributor

jdemel commented Jan 30, 2024

@argilo could the address in the homebrew build error be the culprit:
stop reason = EXC_BAD_ACCESS (code=2, address=0x100044000) ?
It's a wild guess but it might be an issue with the int16 uint16 type thing that you fixed in another commit.
In any case, the leading 1 in the address made me suspicious.

@jdemel
Copy link
Contributor

jdemel commented Jan 30, 2024

On a different note: Github seems to offer paid M1 CI on large/xlarge instances. Someone posted an ad in a corresponding thread and referred to FlyCI. This might be an option for us. At least, it might improve our process.

@argilo
Copy link
Member Author

argilo commented Jan 30, 2024

It's a wild guess but it might be an issue with the int16 uint16 type thing that you fixed in another commit.

I expect #740 is the change you had in mind. It also touched volk_16u_byteswap_a_orc in this release, so it makes sense to treat it with suspicion.

@argilo
Copy link
Member Author

argilo commented Jan 30, 2024

Without a stack trace or debug symbols it's hard to know for sure what's going on. I hope tha @chenrui333 might be able to help diagnose this.

@argilo argilo marked this pull request as draft January 30, 2024 21:34
@argilo
Copy link
Member Author

argilo commented Jan 30, 2024

I converted this to a draft until we have confirmation that this protokernel is the cause of #745.

@argilo
Copy link
Member Author

argilo commented Feb 1, 2024

I used FlyCI to build VOLK on M1 with ORC support, and didn't observe any failures after trying out several configurations. I'll close this PR off for now, since there's not much reason to suspect that volk_16u_byteswap_a_orc was the cause of the test failure that Homebrew observed.

Without diagnostic information, I'm afraid there's not much more I can do to troubleshoot.

@argilo argilo closed this Feb 1, 2024
@argilo argilo deleted the remove-16u-byteswap-orc branch February 1, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

volk 3.1.1 regression test failure
2 participants