Replace sse2neon with native NEON #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clayton Smith <[email protected]>
|
Merging this PR and waiting for #756 to be rebased. I appreciate that the code seems to simplify. |
Alesha72003
pushed a commit
to Alesha72003/volk
that referenced
this pull request
May 15, 2024
Replace sse2neon with native NEON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
volk_8u_x4_conv_k7_r2_8u_neonspiralis the only protokernel that needs sse2neon, which has proven to be a troublesome dependency. Here I've rewritten the protokernel in native NEON, eliminating the need for sse2neon.Now that the
volk_8u_x4_conv_k7_r2_8ukernel is adequately tested, we can be confident that the updated protokernel is correct.Performance is more or less unchanged:
Old:
New: