Update descendreport.py

[dave-khuon]

Add an option to insert a gender symbol before the person's name

[dave-khuon]

With Test Results as suggested:
TestResults-DescendReport.pdf

[dave-khuon]

What's next for me to do for this PR? I am new to this process.

[giotodibondone]

Thanks for the PR's

Looking at Gramps Committing policies on the wiki it shows

Pull requests must be code-reviewed and tested by a developer.

https://www.gramps-project.org/wiki/index.php/Committing_policies#Pull_requests

Also give others time to test and provide feedback and respond to said feedback 👍 keep in mind the festive season is upon us all!

On the wiki I'm slowly going over the existing reports to show if that report supports the options you want at a glance! One of those is "Genealogical Symbols" which your PR's come under but the only report I've come across so far that uses it is the "Hourglass Graph" that uses "[ ] Show symbols for events" - Show genealogical symbols for birth, marriage and death events" but your PR's reads (as I have not tested) that it is only to print a gender symbol before the person's name. ( "[ ]Show gender symbol" ) which I believe should be changed to ( "Show gender symbol in front of name" ) to be clearer and not mix-up the two options please.

PS: Be a bit more descriptive in the PR subject line to entice others to look at your PR's

• Update descendreport.py #1820 - Add an option to insert a gender symbol before the person's name
• Update detdescendantreport.py #1819 - Add an option to insert a gender symbol before the person's name
• Update detancestralreport.py #1818 - Add an option to insert a gender symbol before the person's name

[Call-Me-Dave]

@giotodibondone The other two PR's use "Include gender symbol" so two ways of describing the same option ☹

Maybe for this Descendant Report a new tab called "Include" should be created and all those option at the bottom moved to that tab so the report options match the other two reports?

[dave-khuon]

Thanks for all your feedback. I will incorporate them into my next modification on each of these 3 reports. I am waiting a little bit longer to see any other suggestions that I need to address. PS: once all the suggestions can be met, do I need to create new PRs to submit the changes, or is there a different path to get new changes to the reviewers again. How do we check off the issues?

…

On Mon, Dec 16, 2024, 5:21 PM Call-Me-Dave ***@***.***> wrote: @giotodibondone <https://github.com/giotodibondone> The other two PR's use "*Include gender symbol*" so two ways of describing the same option ☹ — Reply to this email directly, view it on GitHub <#1820 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2TV3MMQDD36NRKW7B3IPD2F5N6DAVCNFSM6AAAAABTGNMBMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBXGEYDEMRQGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>