Enhancements to Selector Dialogs #1836
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a Path column to the SelectObject dialog to make it easier to choose between media with the same title
Basic MultiTreeView now inherits from PersistentTreeView rather than directly from Gtk.TreeView The clipboard version of MultiTreeView now inherits from MultiTreeView and only adds clipboard specific functionality.
|
Each commit in the PR handles a single problem but I'm happy to split into multiple PRs if that is preferred. |
Allow the client to permit multiple selection. Defaults to single selection for backwaards compatibility. If multiple selection is enabled, the run() method returns a list of handles. The list my be empty.
The previous single thumbnail preview is replaced with a ScrolledWindow containing an IconView.
If multiple objects are selected, add all references immediately to avoid a chain of EditMediaRef dialogs being displayed. The user can manually edit the MediaRef if required If only a single object is selected, show the EditMediaRef dialog
stevenyoungs
force-pushed
the
selectordlg_enhancements
branch
from
55ce7c8 to
58cfb4a
Compare
|
Adding the search bar to the Select Person Dialog seems like an obvious thing to do. |
|
Addresses mantis feature request 683 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of enhancements to the selector dialogs:
SelectObject)See image 2 below
SelectPerson)See image 1 below
BaseSelectorclassThis includes unifying the two different
MultiTreeViewclasses in grampsThe existing single thumbnail is replaced with a
ScrolledWindowcontaining anIconViewSee image 2 below
GalleryTabIf this PR is accepted, a follow on PR can add support for multiple selection to other selector dialogs. Examples could include: sharing multiple children to a family, sharing multiple events to a person
Currently, where only a single media object can be selected, the Edit Media Ref dialog is shown immediately after selection. The media ref is only added to the primary object when OK is selected from the Edit Media Ref dialog. This PR preserves this behaviour if the user only selects a single object. If multiple media objects are selected by the user, the media refs are immediately created and added. No Edit Media Ref dialogs are shown. The user can manually edit the media ref, using existing GalleryTab functionality (e.g. double click the thumbnail) as required. This avoids a poor user experience of multiple Edit Media Ref dialogs appearing all at once, or in a sequence. It also mirrors the behaviour of drag and drop of multiple files on to the gallery tab.
Image 1
Image 2