Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initital Hono grafserv adapter #2297

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Initital Hono grafserv adapter #2297

wants to merge 10 commits into from

Conversation

olup
Copy link

@olup olup commented Jan 3, 2025

Description

This PR adds a initial Hono adapter to grafserv. I won't handle bufferStream or websockets yet.

Performance impact

n/a

Security impact

unknown

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • [?] I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

Copy link

changeset-bot bot commented Jan 3, 2025

⚠️ No Changeset found

Latest commit: bf2a347

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@olup olup changed the title feat: initial hono implementation Initital Hono grafserv adapter Jan 3, 2025
@olup olup marked this pull request as draft January 5, 2025 06:32
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see work being done on this! Suggest that you find other people using hono to validate the approach - feel free to ask around in #watercooler on the Discord.

grafast/grafserv/src/servers/hono/v4/index.ts Outdated Show resolved Hide resolved
grafast/grafserv/src/servers/hono/v4/index.ts Outdated Show resolved Hide resolved
grafast/grafserv/src/servers/hono/v4/index.ts Outdated Show resolved Hide resolved
grafast/grafserv/src/servers/hono/v4/index.ts Outdated Show resolved Hide resolved
grafast/grafserv/src/servers/hono/v4/index.ts Outdated Show resolved Hide resolved
@olup olup marked this pull request as ready for review January 5, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🌳 Triage
Development

Successfully merging this pull request may close these issues.

2 participants