Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note stating Subscriptions are out of scope #202

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Add note stating Subscriptions are out of scope #202

merged 1 commit into from
Jul 14, 2022

Conversation

benjie
Copy link
Member

@benjie benjie commented Jul 14, 2022

As suggested by @rivantsov in #183 (comment)

(Non-normative, merge if happy.)

@benjie benjie requested a review from ghmcadams July 14, 2022 13:22
@benjie benjie mentioned this pull request Jul 14, 2022
Open
n1ru4l
n1ru4l approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😁

@ghmcadams ghmcadams merged commit d002775 into main Jul 14, 2022
@benjie benjie deleted the no-subscriptions branch July 14, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n1ru4l n1ru4l n1ru4l approved these changes

@spawnia spawnia spawnia approved these changes

@ghmcadams ghmcadams Awaiting requested review from ghmcadams

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benjie @spawnia @n1ru4l @ghmcadams