Various cleanups #26
Various cleanups #26
Conversation
| "prepare": "husky install" | ||
| }, | ||
| "prettier": { | ||
| "singleQuote": true, |
There was a problem hiding this comment.
I just did this to match what the code style was previously @gskril
Checking often for a diff via ./node_modules/.binprettier --write "**/**"
There was a problem hiding this comment.
There is already a .prettierrc file, I'd prefer to stick with that and the existing sorter plugin. I'll open a PR on your branch for some small suggestions including this
|
Thanks for all your work on this @dawsbot! Working my way through reviewing everything now. When I wipe the db and do a fresh install:
I get the following error Have you run into this? |
|
I haven't tried a Perhaps that relates? Try a |
|
Ah, I assumed usage of bun based on changing the start script to |
src/api/cast.ts
Outdated
| @@ -8,17 +8,19 @@ import { formatCasts } from '../lib/utils.js' | |||
| * Insert casts in the database | |||
| * @param msg Hub event in JSON format | |||
| */ | |||
| export async function insertCasts(msgs: Message[]) { | |||
| export async function insertCasts(msgs: Message[]): Promise<void> { | |||
There was a problem hiding this comment.
I'm generally in the camp of inferring return types where possible, in which case this feels overly verbose. Most of the reasoning is here https://www.youtube.com/watch?v=I6V2FkW1ozQ
I can be convinced otherwise though
There was a problem hiding this comment.
You've convinced me, I didn't know that from the video! Will update 🫡
I've never used their package manager, but honestly your call! I like the ability to opt-out if we start using syntax which is not yet supported by bun. It's not full featured, I've ran into edge-cases prior |
Peace-of-mind changes:
transaction" instead of "trx")