[wip] Load type infos correctly #11
Open
+103
−517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the loading of type infos in
GoSourceFile.Incubate
such that mutation tests should no longer fail, a bug that had been introduced in #5. With this PR, all tests and mutation tests seem to run fine for me.I did have to explicitly disable
ooze_test.TestOoze_nothing_to_test
andooze_test.TestOoze_with_mutations
. These tests do not use regular Go source files on disk, but rather in-memory source "files". Perhaps these should be changed to regular files.This PR is still a work in progress because of those disabled tests.
I have removed
go:build testdata
flags from all Go source files intestdata
folders. For one, they don't seem to be necessary at all, and two, they prevent this PR from working.This PR supersedes #10.