Update request for project related resources; Cleanup to match back-end #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jeffdaley
commented
Nov 7, 2023
•
jeffdaley
commented
- Updates the Project requests to grab the related resources separately.
- Renames stuff to align with the back end
- Cleanup and note-to-self
jeffdaley
commented
Nov 7, 2023
Comment on lines
-519
to
-536
| /** | ||
| * Used by the /projects route to fetch a list of projects. | ||
| */ | ||
| this.get("/projects", () => { | ||
| const projects = this.schema.projects.all().models; | ||
| return new Response(200, {}, projects); | ||
| }); | ||
|
|
||
| /** | ||
| * Used by the /projects/:project_id route to fetch a single project. | ||
| */ | ||
| this.get("/projects/:project_id", (schema, request) => { | ||
| const project = schema.projects.findBy({ | ||
| id: request.params.project_id, | ||
| }); | ||
| return new Response(200, {}, project.attrs); | ||
| }); | ||
|
|
There was a problem hiding this comment.
These were duplicates. Probably a merge error.
jeffdaley
changed the title
Merged
jfreda
approved these changes
Nov 8, 2023
Comment on lines
+23
to
+24
| jiraIssueID?: string; | ||
| jiraIssue?: JiraIssue; |
There was a problem hiding this comment.
Is jiraIssueID supposed to represent the internal Jira ID (if so, curious how we use that)? Can we put that as part of a JiraIssue? Note/caveat: I haven't dove into the Jira part of the backend work yet so I'm cool with this changing as we start to incorporate that.
There was a problem hiding this comment.
I interpreted JiraIssueID to be an external reference, like "LABS-123" (as in test-org.atlassian.com/issues/LABS-123 that would be used to query the Jira API for the full JiraIssue object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.