Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UX of transferring a restricted draft #648

Merged
merged 11 commits into from
Mar 15, 2024
Merged

Improve UX of transferring a restricted draft #648

merged 11 commits into from
Mar 15, 2024

Conversation

jeffdaley
Copy link
Contributor

  • Moves the "Doc transferred" modal to the Modals component, where it can be accessed outside of the document route, such as when transferring ownership of a restricted draft, which now redirects gracefully to the dashboard.
  • Adds a data property to the ActiveModalService to temporarily store route-agnostic information for use in the template.
  • Converts the Modals component to gts for tighter enum handling
  • Renames some ModalService properties for brevity; adds documentation

@jeffdaley jeffdaley mentioned this pull request Mar 13, 2024
Closed
@jeffdaley jeffdaley marked this pull request as ready for review March 13, 2024 22:13
@jeffdaley jeffdaley requested a review from a team as a code owner March 13, 2024 22:13
@jeffdaley jeffdaley merged commit 0e7992b into main Mar 15, 2024
1 check passed
@jeffdaley jeffdaley deleted the jeffdaley/transfer-draft branch March 15, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreda jfreda jfreda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffdaley @jfreda