Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimxrt1010_evk: double stack size to allow net_lwip_webserver to run #531

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

majbthrd
Copy link
Collaborator

@majbthrd majbthrd commented Oct 7, 2020

#289 reported an issue with net_lwip_webserver with the 'NXP Transdimension (18 / 43 / iMX RT)' target.

I had access to a MIMXRT1010_EVK, and the issue was nothing more than a too restrictive stack size in NXP's default stack size value in the linker script. A minor tweak to the BSP board.mk by adding LDFLAGS to override the value remedies this.

I suspect the same change will remedy others (most notably the MIMXRT1015_EVK, which should be nearly identical to the MIMXRT1010_EVK), but I'll defer this to people who have these platforms and can confirm this.

Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks. Do you know where is the line that make use of stack overflow e.g local dynamic array. I try to see if we could bring it to for say global scope to avoid stack overflow like this.

@majbthrd
Copy link
Collaborator Author

majbthrd commented Oct 8, 2020

The heavy stack usage is pervasive throughout lwip; every TCP/IP stack that I've ever encountered has been like this.

Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super finding. Don't worry about the rest of the family. I will pull them out in the weekend to test with 👍

@hathach hathach merged commit 6f8d0d2 into hathach:master Oct 8, 2020
@majbthrd majbthrd deleted the mimxrt1010stack branch October 11, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants