Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nx #61

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Update nx #61

merged 2 commits into from
Aug 20, 2024

Conversation

Brocco
Copy link
Contributor

@Brocco Brocco commented Aug 19, 2024

No description provided.

dwelch2344
dwelch2344 approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@dwelch2344 dwelch2344 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Does the vscode launch config work cross-platform? Approving either way, but let's open a ticket to make sure the big 3 work as expected if not

@Brocco Brocco merged commit 18444a3 into herodevs:main Aug 20, 2024
14 checks passed
@Brocco Brocco deleted the update-nx branch August 20, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwelch2344 dwelch2344 dwelch2344 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Brocco @dwelch2344