Sim catalog #803
Sim catalog #803
Conversation
| @@ -1013,6 +1014,9 @@ def attempt_scan( | |||
| break | |||
| if success: | |||
| break | |||
| if t is None: | |||
| import pdb | |||
| pdb.set_trace() | |||
There was a problem hiding this comment.
Did you intend to leave this debugger call here (rather than raising an exception, etc)?
| # This operator is based on a Simons Observatory source file, | ||
| # https://github.com/simonsobs/sotodlib/blob/master/sotodlib/toast/ops/sim_catalog.py | ||
|
|
||
| # Copyright (c) 2018-2024 Simons Observatory. | ||
| # Full license can be found in the top level "LICENSE" file. |
There was a problem hiding this comment.
Since you were the original author of that code, I would remove these lines.
|
|
||
| self.detector_pointing.apply(obs_data, detectors=[det]) | ||
| try: | ||
| det_quat = obs_data.obs[0].detdata[self.detector_pointing.quats][det] |
There was a problem hiding this comment.
You could also just do obs.detdata[...].
| import pdb | ||
|
|
||
| pdb.set_trace() |
There was a problem hiding this comment.
Maybe log an error and re-raise the exception here?
| detector_pointing = Instance( | ||
| klass=Operator, | ||
| allow_none=True, | ||
| help="Operator that translates boresight Az/El pointing into detector frame", |
There was a problem hiding this comment.
Shouldn't this be Ra/Dec frame?
|
|
||
| pdb.set_trace() | ||
|
|
||
| # Convert Az/El quaternion of the detector into angles |
There was a problem hiding this comment.
Hopefully these are Ra/Dec quaternions...
| import pdb | ||
|
|
||
| pdb.set_trace() |
There was a problem hiding this comment.
More debugging things to remove
| ) | ||
|
|
||
| outfile = os.path.join(self.outdir, "map.png") | ||
| fig.savefig(outfile) |
There was a problem hiding this comment.
Having a visual check is great. If the sources were bright enough we might even be able to look at the relevant pixel closest to the source and confirm the map value is close to expected.
Generalization of the SO point source simulation module with an important bugfix for HWP-modulated cases.