Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update armeria to 1.31.0 #560

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Update armeria to 1.31.0 #560

merged 2 commits into from
Nov 19, 2024

Conversation

http4s-steward[bot]
Copy link
Contributor

About this PR

📦 Updates com.linecorp.armeria:armeria from 1.30.1 to 1.31.0

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.linecorp.armeria", artifactId = "armeria" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.linecorp.armeria", artifactId = "armeria" }
}]
labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Comment on lines +256 to +261
atBuild(
_.tlsProvider(
TlsProvider
.builder()
.keyPair(TlsKeyPair.of(keyFile, keyPassword.orNull, keyCertChainFile))
.build()))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes addressing the armeria upgrade are quite trivial, but it'd be nice if @ikhoon took a quick look at it 🙇🏻‍♂️

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm late.

  • A recommended API is _.tls(TlsKeyPair.of(keyCertChainFile, keyPassword.orNull, keyFile)) because it reuses Netty's SslContext for the server's lifecycle.
  • However, TlsProvider also works, which destroys unused SslContext and recreates if a new connection is established.

@danicheg
Copy link
Member

Well, changes are quite isolated, so merging this

@danicheg danicheg merged commit 88accc5 into main Nov 19, 2024
10 checks passed
@danicheg danicheg deleted the update/armeria-1.31.0 branch November 19, 2024 08:35
@danicheg
Copy link
Member

@ikhoon thank you for the review! I'll address your suggestions asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants