feat: UI for adding alerts for dashboard tiles #562

ernestii · 2025-01-20T18:37:30Z

changeset-bot · 2025-01-20T18:37:34Z

🦋 Changeset detected

Latest commit: 6616f30

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/api/src/controllers/dashboard.ts

wrn14897 · 2025-01-22T01:45:40Z

packages/api/src/controllers/dashboard.ts

+    await Alert.find({
+      dashboard: { $in: _dashboards.map(d => d._id) },
+      source: 'tile',
+    }),


double check we want to select all fields from the alert?

yep, I think all data is fine, we need full channel to populate the form

wrn14897 · 2025-01-22T01:50:25Z

packages/api/src/controllers/dashboard.ts

+      ...d,
+      tiles: d.tiles.map(t => ({
+        ...t,
+        config: { ...t.config, alert: alertsByTileId[t.id]?.[0] },


any reason we want to add alert field to config instead of adding it to the top level?

the reason what that it's easier to integrate alert form into Edit Chart form, since we can use same react-hook-form controller (it uses SavedChartConfig schema)

packages/api/src/controllers/dashboard.ts

wrn14897 · 2025-01-22T05:29:35Z

packages/api/src/controllers/dashboard.ts

+  // Create related alerts
+  for (const tile of dashboard.tiles) {
+    if (!tile.config.alert) {
+      await Alert.findOneAndUpdate(
+        {
+          dashboard: newDashboard._id,
+          tileId: tile.id,
+          source: 'tile',
+          team: teamId,
+        },
+        { ...tile.config.alert },
+        { new: true, upsert: true },
+      );
+    }
+  }


hmm...maybe we don't want to create an alert here (SRP). I wonder if we should fire a request at the modal level instead

I'm kinda on the fence... i think this implementation is more convenient in terms of API, as it prevents partial failure scenario on FE + easier to build forms (as long as tile.config.alert is always consistent with Alert type)

lmk if we should implement it the way we did in the v1

packages/api/src/controllers/dashboard.ts

ernestii · 2025-01-24T04:56:42Z

rebased and added team: teamId filters, going to address the rest tmr

ernestii marked this pull request as draft January 20, 2025 18:37

ernestii force-pushed the ernest-/hdx-1303-tiles-alerting-ui branch 5 times, most recently from a813a05 to 9aa649b Compare January 20, 2025 21:33

ernestii marked this pull request as ready for review January 20, 2025 21:34

ernestii requested review from MikeShi42 and wrn14897 January 20, 2025 21:34

ernestii force-pushed the ernest-/hdx-1303-tiles-alerting-ui branch from 9aa649b to 67ee87d Compare January 21, 2025 04:10

ernestii force-pushed the ernest-/hdx-1329-saved-search-alert-ui-threshold-chart branch 2 times, most recently from 21dcf30 to a90737e Compare January 21, 2025 04:36

ernestii force-pushed the ernest-/hdx-1303-tiles-alerting-ui branch 3 times, most recently from 6dda29e to 052e209 Compare January 21, 2025 05:34

ernestii force-pushed the ernest-/hdx-1329-saved-search-alert-ui-threshold-chart branch from a90737e to a41f979 Compare January 21, 2025 05:48

ernestii force-pushed the ernest-/hdx-1303-tiles-alerting-ui branch from 052e209 to e7e9885 Compare January 21, 2025 05:48